[
https://issues.apache.org/jira/browse/GEODE-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198395#comment-17198395
]
ASF GitHub Bot commented on GEODE-8506:
---------------------------------------
Bill commented on a change in pull request #5525:
URL: https://github.com/apache/geode/pull/5525#discussion_r490654223
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java
##########
@@ -98,14 +101,18 @@ private ByteBuffer acquireDirectBuffer(int size, boolean
send) {
if (useDirectBuffers) {
if (size <= MEDIUM_BUFFER_SIZE) {
- return acquirePredefinedFixedBuffer(send, size);
+ result = acquirePredefinedFixedBuffer(send, size);
Review comment:
The comment on method `acquirePredefinedFixedBuffer()` now lies. It says:
```
/**
* Acquire direct buffer with predefined default capacity (4096 or 32768)
*/
```
But that method no longer returns buffers with predefined _capacity_.
~Also that method's name seems wrong since it doesn't return a buffer with a
predefined capacity at all, rather, it returns a buffer of the specified
`size`.~ brainf*rt
If I am understanding the method in question, perhaps this would be more
accurate (also eliminates the word "fixed" from the method name since I don't
think that is pertinent):
```
/**
* Acquire direct buffer of size <= MEDIUM_BUFFER_SIZE
*
* Caller ensures that size <= MEDIUM_BUFFER_SIZE on entry. This method
* will not check that!
*/
private ByteBuffer acquireSmallToMediumBuffer(boolean send, int size) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> BufferPool returns byte buffers that may be much larger than requested
> ----------------------------------------------------------------------
>
> Key: GEODE-8506
> URL: https://issues.apache.org/jira/browse/GEODE-8506
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Labels: pull-request-available
>
> BufferPool manages several pools of direct-memory ByteBuffers. When asked
> for a ByteBuffer of size X you may receive a buffer that is any size greater
> than or equal to X. For users of this pool this is unexpected behavior and
> is causing some trouble.
> MessageStreamer, for instance, performs message "chunking" based on the size
> of a socket's buffer size. It requests a byte buffer of that size and then
> fills it over and over again with message chunks to be written to the socket.
> But it does this based on the buffer's capacity, which may be much larger
> than the expected buffer size. This results in incorrect chunking and
> requires larger buffers in the receiver of these message chunks.
> BufferPool should always return a buffer that has exactly the requested
> capacity. It could be a _slice_ of a pooled buffer, for instance. That
> would let it hand out a larger buffer while not confusing the code that
> requested the buffer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
