[
https://issues.apache.org/jira/browse/GEODE-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196200#comment-17196200
]
ASF GitHub Bot commented on GEODE-8489:
---------------------------------------
agingade commented on a change in pull request #5507:
URL: https://github.com/apache/geode/pull/5507#discussion_r488723747
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java
##########
@@ -30,14 +31,16 @@
import org.apache.geode.cache.RegionShortcut;
import org.apache.geode.management.DistributedSystemMXBean;
import org.apache.geode.management.internal.json.QueryResultFormatter;
+import org.apache.geode.management.model.Employee;
import org.apache.geode.test.junit.assertions.TabularResultModelAssert;
import org.apache.geode.test.junit.rules.GfshCommandRule;
import org.apache.geode.test.junit.rules.MBeanServerConnectionRule;
import org.apache.geode.test.junit.rules.ServerStarterRule;
public class DistributedSystemMBeanIntegrationTest {
- public static final String SELECT = "select * from /testRegion r where
r.id=1";
+ public static final String SELECT_ALL = "select * from /testRegion r where
r.id=1";
Review comment:
Can we add a query that returns 0 results. And verify the results are
shown as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should keep the 1.8 behavior when doing a "Select *" query
> ----------------------------------------------------------------
>
> Key: GEODE-8489
> URL: https://issues.apache.org/jira/browse/GEODE-8489
> Project: Geode
> Issue Type: Bug
> Components: management
> Affects Versions: 1.10.0, 1.9.2, 1.11.0, 1.13.0
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> After the TypedJson refactor, we see those different behaviors when using
> DistributedSysteemMBean to do a "select *" query:
> 1. Jackson Json Annotations are taking into effect now. "Select *" won't show
> those `@JsonIgnore` fields anymore. And "JsonProperty" annotation values are
> showing up as headers
> 2. null values fields are not showing up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
