[
https://issues.apache.org/jira/browse/GEODE-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195726#comment-17195726
]
ASF GitHub Bot commented on GEODE-8492:
---------------------------------------
sabbeyPivotal commented on a change in pull request #5510:
URL: https://github.com/apache/geode/pull/5510#discussion_r488191271
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -177,6 +177,10 @@ public void removeClient() {
stats.incLong(clientId, -1);
}
+ public long getClients() {
Review comment:
Just added it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis "clients" statistic goes negative
> ---------------------------------------
>
> Key: GEODE-8492
> URL: https://issues.apache.org/jira/browse/GEODE-8492
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Sarah Abbey
> Priority: Minor
> Labels: pull-request-available
>
> When running a long running app, we noticed that our "clients" statistic was
> negative. It should always be greater than or equal to 0.
> It seems like the call to decrement the number of clients was being invoked
> multiple times for each client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
