[
https://issues.apache.org/jira/browse/GEODE-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193213#comment-17193213
]
ASF GitHub Bot commented on GEODE-8486:
---------------------------------------
DonalEvans commented on a change in pull request #5500:
URL: https://github.com/apache/geode/pull/5500#discussion_r485950037
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
##########
@@ -146,7 +146,9 @@
/** keeps track of events, so as not to re-apply events */
protected Set<EventID> seenEvents = new HashSet<EventID>();
/** keeps track of results of txPutEntry */
- private Map<EventID, Boolean> seenResults = new HashMap<EventID, Boolean>();
+ private Map<EventID, Boolean> seenResults = new HashMap<>();
+ /** keeps track of TransactionDataRebalancedException during txPutEntry */
+ private Map<EventID, TransactionDataRebalancedException> failedExceptions =
new HashMap<>();
Review comment:
This might be better named "failedEvents" or "eventExceptions."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Transaction should save TransactionDataRebalancedException during txPutEntry
> -----------------------------------------------------------------------------
>
> Key: GEODE-8486
> URL: https://issues.apache.org/jira/browse/GEODE-8486
> Project: Geode
> Issue Type: Bug
> Components: transactions
> Affects Versions: 1.1.0
> Reporter: Eric Shu
> Assignee: Eric Shu
> Priority: Major
> Labels: caching-applications, pull-request-available
>
> Transaction should save TransactionDataRebalancedException during
> txPutEntry().
> Currently, it only save the result of txPutEntry, which is used for handling
> a retry of an operation in a transaction. This is not enough for handling a
> retry, as a simply returns of the failed operation does not really represents
> the original operation result.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
