[
https://issues.apache.org/jira/browse/GEODE-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193030#comment-17193030
]
ASF GitHub Bot commented on GEODE-8485:
---------------------------------------
jchen21 commented on a change in pull request #5499:
URL: https://github.com/apache/geode/pull/5499#discussion_r485769839
##########
File path:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcherJUnitTest.java
##########
@@ -54,4 +58,22 @@ public void
shuttingDownAckThreadReaderConnectionShouldshutdownTheAckThreadReade
dispatcher.shutDownAckReaderConnection();
assertTrue(ackReaderThread.isShutdown());
}
+
+ @Test
+ public void getConnectionShouldCreateNewConnectionWhenServerIsNull() {
+ AbstractGatewaySender sender = mock(AbstractGatewaySender.class);
+ when(sender.isParallel()).thenReturn(false);
+ AbstractGatewaySenderEventProcessor eventProcessor =
+ mock(AbstractGatewaySenderEventProcessor.class);
+ when(eventProcessor.getSender()).thenReturn(sender);
+ Connection connection = mock(Connection.class);
+ when(connection.isDestroyed()).thenReturn(false);
+ when(connection.getServer()).thenReturn(null);
+ GatewaySenderEventRemoteDispatcher dispatcher =
+ new GatewaySenderEventRemoteDispatcher(eventProcessor, connection);
+ dispatcher = spy(dispatcher);
+ doNothing().when(dispatcher).initializeConnection();
+ Connection newConnection = dispatcher.getConnection(true);
Review comment:
You can also assert `getConnection` does not throw NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When connection is closed, its server could be null
> ---------------------------------------------------
>
> Key: GEODE-8485
> URL: https://issues.apache.org/jira/browse/GEODE-8485
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Xiaojian Zhou
> Assignee: Xiaojian Zhou
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> java.lang.NullPointerException
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299)
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher._dispatchBatch(GatewaySenderEventRemoteDispatcher.java:188)
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.dispatchBatch(GatewaySenderEventRemoteDispatcher.java:155)
> at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:639)
> at
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderEventProcessor.run(SerialGatewaySenderEventProcessor.java:219)
> It's checking if need to create a new connection. In this context, it's
> possible that connection.getServer()==null
> When we detected it, let it create a new connection.
> We catch all exception including NPE, and retry for all failure in dispatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
