[
https://issues.apache.org/jira/browse/GEODE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192971#comment-17192971
]
ASF GitHub Bot commented on GEODE-8449:
---------------------------------------
echobravopapa commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r485715946
##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -34,6 +34,8 @@ public class SNITests : TestBase, IDisposable
public SNITests(ITestOutputHelper testOutputHelper) :
base(testOutputHelper)
{
+ Dispose();
Review comment:
does this make sense for C# language? using the `Dispose` method...?
##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
~SNITest() override = default;
void SetUp() override {
+ TearDown();
Review comment:
same thing here... `gtest` uses `TearDown` as a special method... I
wonder if it would be better to have a utility method for both that is called
from the constructor in C# and `SetUp` in this test...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Clean up docker containers in Tests
> -----------------------------------
>
> Key: GEODE-8449
> URL: https://issues.apache.org/jira/browse/GEODE-8449
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> As a developer it would be very nice to have docker containers in an
> appropriate state for each test run that requires them... currently a
> failing test leaves around containers that will most likely cause trouble
> with a subsequent test run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
