[
https://issues.apache.org/jira/browse/GEODE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188935#comment-17188935
]
ASF GitHub Bot commented on GEODE-8469:
---------------------------------------
moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481562738
##########
File path: tests/cpp/security/XmlAuthzCredentialGenerator.hpp
##########
@@ -55,7 +55,7 @@ const opCodeList::value_type QArr[] = {OP_QUERY,
OP_REGISTER_CQ};
const stringList::value_type QRArr[] = {"Portfolios", "Positions"};
-const char* PRiUsnm = "%s%d";
+static const char* PRiUsnm = "%s%d";
Review comment:
It did not. `ISO C++11 does not allow conversion from string literal to
'char *const'` is the specific error when trying to use it while on a mac.
Haven't looked more into at the moment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce no-missing-variable-declarations
> ----------------------------------------
>
> Key: GEODE-8469
> URL: https://issues.apache.org/jira/browse/GEODE-8469
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-missing-variable-declarations
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
