[
https://issues.apache.org/jira/browse/GEODE-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Oleske updated GEODE-8468:
----------------------------------
Labels: GoodForNewContributors (was: )
> Review use of switch statements with enums
> ------------------------------------------
>
> Key: GEODE-8468
> URL: https://issues.apache.org/jira/browse/GEODE-8468
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: GoodForNewContributors
>
> We should check our usage of switch statements with enums
> Before we add more enums
> Because readability is important
> Notes: While working on GEODE-8340, it was determined that some of the
> places where a switch statement over enums was used were cases where a switch
> statement was not the best control structure. The goal here is prevent a
> long unwieldy list of switch statements. There are a lot of places to
> review, so it will probably be easiest to do this over several PRs, which may
> require several stories. The places listed below does not mean all of them
> need to be fixed, but they should all be reviewed for improvement. For
> further context, check out the comments on the [pr for
> 8340|https://github.com/apache/geode-native/pull/625]
> cppcache/integration-test/testThinClientCq.cpp at line 156ish
> cppcache/integration-test/testThinClientCq.cpp at line 220ish
> cppcache/integration-test/testThinClientCqDurable.cpp at line 125ish
> cppcache/integration-test/testThinClientSecurityCQAuthorizationMU.cppline
> 119ish
> cppcache/integration-test/testThinClientSecurityDurableCQAuthorizationMU.cpp
> at line 1229ish
> cppcache/integration/test/SimpleCqListener.cpp at line 43ish
> cppcache/src/CqQueryImpl.cpp at line 548ish
> cppcache/src/CqService.cpp at line 71ish
> cppcache/src/LRUAction.cpp at line 47ish
> cppcache/src/LocalRegion.cpp at line 2586ish
> cppcache/src/LocalRegion.cpp at line 2639ish
> cppcache/src/LocalRegion.cpp at line 2696ish
> cppcache/src/LocalRegion.cpp at line 2715ish
> cppcache/src/LocalRegion.cpp at line 2781ish
> cppcache/src/PdxInstanceImpl.cpp at line 247ish
> cppcache/src/PdxInstanceImpl.cpp at line 485ish
> cppcache/src/PdxInstanceImpl.cpp at line 667ish
> cppcache/src/PdxInstanceImpl.cpp at line 1136ish
> cppcache/src/SerializationRegistry.cpp at line 182ish
> cppcache/src/SerializationRegistry.cpp at line 259ish
> cppcache/src/SerializationRegistry.cpp at line 626ish
> cppcache/src/SerializationRegistry.cpp at line 703ish
> cppcache/src/TcrConnection.cpp at line 1194ish
> cppcache/src/TcrMessage.cpp at line 1015ish
> tests/cpp/fwklib/IpcHandler.cpp at line 231ish
> tests/cpp/security/XmlAuthzCredentialGenerator.hpp at line 107ish
> tests/cpp/security/XmlAuthzCredentialGenerator.hpp at line 162ish
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
