[
https://issues.apache.org/jira/browse/GEODE-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185472#comment-17185472
]
ASF GitHub Bot commented on GEODE-8457:
---------------------------------------
moleske commented on a change in pull request #642:
URL: https://github.com/apache/geode-native/pull/642#discussion_r477581852
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
}
excludeServers.insert(ServerLocation(ep->name()));
if (error == GF_IOERR) {
- auto sl = std::make_shared<BucketServerLocation>(ep->name());
- LOGINFO("Removing bucketServerLocation %s due to GF_IOERR",
- sl->toString().c_str());
- m_clientMetadataService->removeBucketServerLocation(sl);
+ if (m_clientMetadataService != nullptr) {
Review comment:
When I see an `if` statement, I usually think there's a possible test
case. One for when the statement is `true`, and one for `false`. Is it
possible to write a test for this and the below `if` statements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C++ native client crash when singleHop=false and an IO error is detected when
> sending a message to a server
> -----------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8457
> URL: https://issues.apache.org/jira/browse/GEODE-8457
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> The native client crashes when single hop is not enabled and the connection
> to a remote server fails with an IO error (for example when the server goes
> down).
> This crash can be observed when running the
> 'testThinClientPoolExecuteHAFunction'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
