[ 
https://issues.apache.org/jira/browse/GEODE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161916#comment-17161916
 ] 

ASF GitHub Bot commented on GEODE-8364:
---------------------------------------

alb3rtobr commented on a change in pull request #629:
URL: https://github.com/apache/geode-native/pull/629#discussion_r457982869



##########
File path: cppcache/test/CacheTest.cpp
##########
@@ -61,3 +62,10 @@ TEST(CacheTest, close) {
   EXPECT_THROW(cache.readyForEvents(), CacheClosedException);
   EXPECT_THROW(cache.rootRegions(), CacheClosedException);
 }
+
+TEST(CacheTest, changeLogLevel) {
+  auto cache = CacheFactory{}.set("log-level", "info").create();
+  ASSERT_EQ(cache.getLogLevel(), LogLevel::Info);

Review comment:
       I have changed the `setLogLevel` method to also update the log level on 
the `SystemProperties` object.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change log level of C++ client at runtime
> -----------------------------------------
>
>                 Key: GEODE-8364
>                 URL: https://issues.apache.org/jira/browse/GEODE-8364
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Alberto Bustamante Reyes
>            Priority: Major
>              Labels: pull-request-available
>
> Currently it is not possible to change log level of the C++ after it is 
> created.
> It will be useful to have a way to change it at runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to