[
https://issues.apache.org/jira/browse/GEODE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160097#comment-17160097
]
ASF GitHub Bot commented on GEODE-8367:
---------------------------------------
DonalEvans commented on a change in pull request #5381:
URL: https://github.com/apache/geode/pull/5381#discussion_r456569959
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##########
@@ -1034,9 +1036,17 @@ public void distribute(EnumListenerEvent operation,
EntryEventImpl event,
// If this gateway is not running, return
if (!isRunning()) {
if (this.isPrimary()) {
- tmpDroppedEvents.add(clonedEvent);
- if (isDebugEnabled) {
- logger.debug("add to tmpDroppedEvents for evnet {}", clonedEvent);
+ if (this.startTime < 0
+ && System.currentTimeMillis() + this.startTime <
maxWaitTimeForSenderToStart) {
+ tmpDroppedEvents.add(clonedEvent);
+ if (isDebugEnabled) {
+ logger.debug("add to tmpDroppedEvents for evnet {}",
clonedEvent);
+ }
+ } else {
+ if (isDebugEnabled) {
+ logger.debug("The sender is stopped. Not to add to
tmpDroppedEvents for event {}",
Review comment:
This might be worded better as "Gateway sender is stopped. Event was not
added to tmpDroppedEvents: {}"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Stopped parallel gateway sender still adds events into tmpDroppedEvents
> -----------------------------------------------------------------------
>
> Key: GEODE-8367
> URL: https://issues.apache.org/jira/browse/GEODE-8367
> Project: Geode
> Issue Type: Improvement
> Reporter: Xiaojian Zhou
> Priority: Major
> Labels: pull-request-available
>
> In GEODE-4942, we introduced tmpDroppedEvents to save the in-coming events
> when the parallel gateway sender is restarting. However, we did not consider
> the case that the sender could be purposely stopped.
> Even for the stopped sender, the events are continuously saved into
> tmpDroppedEvents, which used a lot of memory.
> We should determine if the sender is in the middle of restarting or purposely
> stopped.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
