[
https://issues.apache.org/jira/browse/GEODE-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144887#comment-17144887
]
ASF GitHub Bot commented on GEODE-8176:
---------------------------------------
jujoramos commented on a change in pull request #5303:
URL: https://github.com/apache/geode/pull/5303#discussion_r445531653
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
##########
@@ -117,19 +116,21 @@ public void testPingWrongServer() {
InternalDistributedMember server2ID = server2.invoke("get ID", () ->
cache.getMyId());
pool = (PoolImpl) createClientCache(NetworkUtils.getServerHostName(),
PORT1);
// send the ping to server1 but use server2's identifier so the ping will
be forwarded
-
ClientProxyMembershipID proxyID = server1.invoke(
() ->
CacheClientNotifier.getInstance().getClientProxies().iterator().next().getProxyID());
logger.info("ProxyID is : " + proxyID);
Review comment:
This logging message can be removed.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
##########
@@ -117,19 +116,21 @@ public void testPingWrongServer() {
InternalDistributedMember server2ID = server2.invoke("get ID", () ->
cache.getMyId());
pool = (PoolImpl) createClientCache(NetworkUtils.getServerHostName(),
PORT1);
// send the ping to server1 but use server2's identifier so the ping will
be forwarded
-
ClientProxyMembershipID proxyID = server1.invoke(
() ->
CacheClientNotifier.getInstance().getClientProxies().iterator().next().getProxyID());
logger.info("ProxyID is : " + proxyID);
server2.invoke(() -> {
assertThat(ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().contains(proxyID))
.isFalse();
- assertEquals(0,
ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().size());
+
assertThat(ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().size())
+ .isEqualTo(0);
});
PingOp.execute(pool, new ServerLocation(NetworkUtils.getServerHostName(),
PORT1), server2ID);
// if the ping made it to server2 it will have the client's ID in its
health monitor
server2.invoke(() -> {
- assertEquals(1,
ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().size());
+ await("For heartbeat to be received").untilAsserted(() -> assertThat(
+
ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().size())
+ .isEqualTo(1));
ClientProxyMembershipID proxyIDFound =
ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().iterator().next();
logger.info("ProxyID found in clientHealthMonitor: " + proxyIDFound);
Review comment:
This logging message can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure: ClientServerMiscBCDUnitTest > testPingWrongServer[1]
> -----------------------------------------------------------------
>
> Key: GEODE-8176
> URL: https://issues.apache.org/jira/browse/GEODE-8176
> Project: Geode
> Issue Type: Bug
> Reporter: Donal Evans
> Assignee: Alberto Bustamante Reyes
> Priority: Major
> Labels: flaky
>
> Failed in
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/192#A
> {noformat}
> org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest >
> testPingWrongServer[1] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.ClientServerMiscDUnitTestBase$$Lambda$310/201549247.run
> in VM 3 running on Host c0a964e32781 with 5 VMs
> Caused by:
> org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>
> {noformat}
> I ran the test 200 times locally with no failure, so this is possibly just a
> blip.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
