[
https://issues.apache.org/jira/browse/GEODE-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143949#comment-17143949
]
ASF GitHub Bot commented on GEODE-8283:
---------------------------------------
jinmeiliao commented on a change in pull request #5288:
URL: https://github.com/apache/geode/pull/5288#discussion_r444989870
##########
File path:
geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.geode.management.configuration;
+
+import java.util.List;
+import java.util.Objects;
+
+import com.fasterxml.jackson.annotation.JsonIgnore;
+
+import org.apache.geode.annotations.Experimental;
+import org.apache.geode.management.runtime.DiskStoreInfo;
+
+@Experimental
+public class DiskStore extends GroupableConfiguration<DiskStoreInfo> {
Review comment:
If it returns null in the `get` method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> REST API for creating diskstores
> --------------------------------
>
> Key: GEODE-8283
> URL: https://issues.apache.org/jira/browse/GEODE-8283
> Project: Geode
> Issue Type: New Feature
> Components: rest (admin)
> Reporter: Jason Huynh
> Assignee: Joris Melchior
> Priority: Major
>
> This is a feature to add a REST API to allow someone to create a diskstore.
> This may include creating a diskstore, deleting a disk store, listing a
> diskstore and possibly revoking a diskstore.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
