[
https://issues.apache.org/jira/browse/GEODE-8247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135070#comment-17135070
]
ASF GitHub Bot commented on GEODE-8247:
---------------------------------------
mkevo commented on a change in pull request #5248:
URL: https://github.com/apache/geode/pull/5248#discussion_r439801370
##########
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
Review comment:
Please change names, e.g. onEventCalls -> **onEventCreateCalls**,
onEventUPDATE -> **onEventUpdateCalls**
##########
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
Review comment:
remove blank line
##########
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
+ }
+
+ @Override
+ public void close() {
+
Review comment:
remove blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CQs sends back wrong event (UPDATE instead of CREATE)
> --------------------------------------------------------
>
> Key: GEODE-8247
> URL: https://issues.apache.org/jira/browse/GEODE-8247
> Project: Geode
> Issue Type: Bug
> Components: cq
> Reporter: Mario Ivanac
> Assignee: Mario Ivanac
> Priority: Major
>
> When updating entries in Partition region, inside transaction,
> CQ sends UPDATE events instead of CREATE.
> Deeper analysis shows, that in failure case,
> FilterProfile.getFilterRoutingInfoPart1 and
> FilterProfile.getFilterRoutingInfoPart2 are called consecutively for the same
> event (CREATE).
> So when getFilterRoutingInfoPart2 calls second time CqService to process the
> same EntryEvent,
> it interprets it as UPDATE.
> {color:#ffc66d} {color}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
