[ https://issues.apache.org/jira/browse/GEODE-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134795#comment-17134795 ]
ASF GitHub Bot commented on GEODE-8128: --------------------------------------- mmartell commented on a change in pull request #616: URL: https://github.com/apache/geode-native/pull/616#discussion_r439739453 ########## File path: cppcache/integration/framework/Cluster.h ########## @@ -171,60 +171,77 @@ class Cluster { const std::string truststorePassword); bool useSsl(); - bool requireSslAuthentication(); - std::string keystore(); - std::string truststore(); - std::string keystorePassword(); - std::string truststorePassword(); - Gfsh &getGfsh(); + void usePropertiesFile(const std::string propertiesFile); + void useSecurityPropertiesFile(const std::string securityPropertiesFile); + void useHostNameForClients(const std::string hostNameForClients); + bool usePropertiesFile(); + bool useSecurityPropertiesFile(); + bool useHostNameForClients(); +bool requireSslAuthentication(); Review comment: Good catch. Looks like tabs set incorrectly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Write basic SNI test > -------------------- > > Key: GEODE-8128 > URL: https://issues.apache.org/jira/browse/GEODE-8128 > Project: Geode > Issue Type: Test > Components: native client > Reporter: Ernest Burghardt > Priority: Major > > test will interact with docker-compose to construct a cluster and proxy, > proxy port host:container will be hardcoded > test will perform simple put/get via sni proxy -- This message was sent by Atlassian Jira (v8.3.4#803005)