[
https://issues.apache.org/jira/browse/GEODE-8246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134373#comment-17134373
]
ASF GitHub Bot commented on GEODE-8246:
---------------------------------------
moleske commented on a change in pull request #618:
URL: https://github.com/apache/geode-native/pull/618#discussion_r439531694
##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -765,18 +766,17 @@ void
ClientMetadataService::markPrimaryBucketForTimeoutButLookSecondaryBucket(
serverLocation, version);
std::shared_ptr<ClientMetadata> cptr = nullptr;
- {
- boost::shared_lock<decltype(m_regionMetadataLock)> lock(
- m_regionMetadataLock);
- const auto& cptrIter = m_regionMetaDataMap.find(region->getFullPath());
- if (cptrIter != m_regionMetaDataMap.end()) {
- cptr = cptrIter->second;
- }
+ boost::shared_lock<decltype(m_regionMetadataLock)> boostRegionMetadataLock(
Review comment:
I feel like a test should have failed cause of this change. Will have
to save looking for that test for another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce No Shadow as Error
> --------------------------
>
> Key: GEODE-8246
> URL: https://issues.apache.org/jira/browse/GEODE-8246
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
>
> Given I compile the code without exempting no-shadow
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
