[ https://issues.apache.org/jira/browse/GEODE-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133619#comment-17133619 ]
ASF GitHub Bot commented on GEODE-8221: --------------------------------------- pivotal-jbarrett opened a new pull request #5244: URL: https://github.com/apache/geode/pull/5244 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Session state not committed prior to servlet output flush with commit valve > enabled > ----------------------------------------------------------------------------------- > > Key: GEODE-8221 > URL: https://issues.apache.org/jira/browse/GEODE-8221 > Project: Geode > Issue Type: Bug > Components: http session > Reporter: Jacob Barrett > Assignee: Jacob Barrett > Priority: Major > > The Tomcat session state module does not commit session data to Geode prior > to servlet output flushing to browser if commit valve is enabled. The commit > valve delays the commit of session state until the of the request scope prior > to closing and ending the current request with the browser. This can result > in some data being sent to the browser asynchronously with the session state > persistence. If the servlet or JSP invokes a flush on output stream, write or > response either explicitly through the flush method or implicitly because of > full buffers then the browser may receive data that instructs it to make > another request. This subsequent request may receive the currently committed > session state prior to the completion of the initial request. -- This message was sent by Atlassian Jira (v8.3.4#803005)