[ 
https://issues.apache.org/jira/browse/GEODE-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132578#comment-17132578
 ] 

ASF GitHub Bot commented on GEODE-8190:
---------------------------------------

yozaner1324 commented on a change in pull request #5234:
URL: https://github.com/apache/geode/pull/5234#discussion_r438314213



##########
File path: gradle/java.gradle
##########
@@ -74,9 +74,9 @@ gradle.taskGraph.whenReady({ graph ->
     }
     jar.metaInf {
       from("$rootDir/geode-assembly/src/main/dist/LICENSE")
-      if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
-        from("$rootDir/NOTICE")
-      }
+//      if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
+//        from("$rootDir/NOTICE")
+//      }

Review comment:
       Nope, not sure where this change came from.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create JBoss Module to load jar with manifest and classpath
> -----------------------------------------------------------
>
>                 Key: GEODE-8190
>                 URL: https://issues.apache.org/jira/browse/GEODE-8190
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Udo Kohlmeyer
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to