[
https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125270#comment-17125270
]
ASF GitHub Bot commented on GEODE-8211:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434814852
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void
shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a
JedisDataException when the command
// returns an error.
- try {
- jedis.shutdown();
- } catch (JedisConnectionException ignore) {
Review comment:
Also, this fix was already reviewed on another branch. I just wanted it
to be isolated on its own PR instead of being part of another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed
> failed with java.net.SocketTimeoutException
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8211
> URL: https://issues.apache.org/jira/browse/GEODE-8211
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Xiaojian Zhou
> Assignee: Darrel Schneider
> Priority: Major
> Labels: flaky
> Fix For: 1.14.0
>
>
> IntegrationTestOpenJDK11 #212. This will occasionally happen.
> org.apache.geode.redis.general.ShutdownIntegrationTest >
> shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED
> redis.clients.jedis.exceptions.JedisConnectionException:
> java.net.SocketTimeoutException: Read timed out
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205)
> at
> redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43)
> at redis.clients.jedis.Protocol.process(Protocol.java:155)
> at redis.clients.jedis.Protocol.read(Protocol.java:220)
> at
> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318)
> at
> redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270)
> at redis.clients.jedis.Jedis.keys(Jedis.java:280)
> at
> org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66)
> Caused by:
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at
> java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.net.SocketInputStream.read(SocketInputStream.java:126)
> at
> redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199)
> ... 7 more
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
