[
https://issues.apache.org/jira/browse/GEODE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125068#comment-17125068
]
ASF GitHub Bot commented on GEODE-8158:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5204:
URL: https://github.com/apache/geode/pull/5204#discussion_r434675268
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -56,6 +57,7 @@ public void shutdownActuallyShutsDownTheServer() {
}
@Test
+ @Ignore("this test is flaky")
Review comment:
I think I figured out why this test was still flaky. I removed this
ignore and added a fix for the flakiness in:
https://github.com/apache/geode/pull/5204/commits/823cf5a5c09002e4e543a48ac3a0c7b70232dcc9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> when redis-bind-address is empty/unspecified bind to all local addresses
> ------------------------------------------------------------------------
>
> Key: GEODE-8158
> URL: https://issues.apache.org/jira/browse/GEODE-8158
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Darrel Schneider
> Priority: Minor
>
> Currently, when the redis-bind-address is not specified or "", the default is
> requested from the operating system (LocalHostUtil.getLocalHost()).
> What it should do instead is use InetAddress.anyLocalAddress().
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
