Blake Bender created GEODE-8220:
-----------------------------------
Summary: Use direct reference to config string in test code,
rather than defined constant + case statement
Key: GEODE-8220
URL: https://issues.apache.org/jira/browse/GEODE-8220
Project: Geode
Issue Type: Improvement
Components: native client
Reporter: Blake Bender
In the geode-native test code, we look up the location of a few items as a
matter of course, so we don't have to have multiple copies of files like SSL
keys floating around in random directories in the source/build trees. The code
to do this uses an enum class for named constants, thusly:
{code:java}
enum class FrameworkVariable {JavaObjectJarPath, GfShExecutable,
TestCacheXmlDir, TestClientSslKeysDir, TestServerSslKeysDir};
const char *getFrameworkString(FrameworkVariable name);
{code}
The enum class here is kind of gratuitous, and could simply be replaced with
something like the following:
{code:java}
namespace FrameworkVariables {
constexpr const char* JavaObjectJarPath = "@<<CMAKE_VARIABLE>>";
}
{code}
The variables could then be directly referenced in test code, rather than
looked up via a function call.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
