[
https://issues.apache.org/jira/browse/GEODE-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124214#comment-17124214
]
ASF GitHub Bot commented on GEODE-8095:
---------------------------------------
jinmeiliao commented on a change in pull request #5195:
URL: https://github.com/apache/geode/pull/5195#discussion_r434108906
##########
File path:
geode-management/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyResponseImpl.java
##########
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.operation;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.geode.management.api.ClusterManagementResult;
+import org.apache.geode.management.runtime.RegionRedundancyStatusSerializable;
+import org.apache.geode.management.runtime.RestoreRedundancyResponse;
+
+public class RestoreRedundancyResponseImpl
Review comment:
> I used serializable in the name because the class is basically a copy
of an existing one with the serializability being a distinguishing feature.
This is one of those points of question where, should I just modify the
RegionRedundancyStatus class to make it serializable?
that one is already DataSerializable, so you shouldn't have to make it
Serializable. I think you can just use whatever they had used as the result
before, just move them to the management module. If the object are used in
locator/server function calls, then they must have been
Serializable/DataSerializable already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create restore redundancy and status redundancy REST API commands
> -----------------------------------------------------------------
>
> Key: GEODE-8095
> URL: https://issues.apache.org/jira/browse/GEODE-8095
> Project: Geode
> Issue Type: Bug
> Components: rest (admin)
> Reporter: Anilkumar Gingade
> Priority: Major
> Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add two REST API commands to allow redundancy to be restored and to check the
> current redundancy status.
> Similar to: https://issues.apache.org/jira/browse/GEODE-7954
> More on restore redundancy can be found at
> https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
