[
https://issues.apache.org/jira/browse/GEODE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113164#comment-17113164
]
ASF GitHub Bot commented on GEODE-8138:
---------------------------------------
sabbeyPivotal commented on a change in pull request #5142:
URL: https://github.com/apache/geode/pull/5142#discussion_r428632736
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
##########
@@ -1312,11 +1313,13 @@ static Class _getAttributeType(String attName) {
m.put(MEMCACHED_BIND_ADDRESS,
"The address the GemFireMemcachedServer will listen on for remote
connections. Default is \"\" which causes the GemFireMemcachedServer to listen
on the host's default address. This property is ignored if memcached-port is
\"0\".");
m.put(REDIS_PORT,
- "The port GeodeRedisServer will listen on. Default is 0. Set to zero
to disable GeodeRedisServer.");
+ "The port Redis API for Geode will listen on. Default is 0");
Review comment:
Yes. Thank you for finding this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve semantics of the redis-port option
> ------------------------------------------
>
> Key: GEODE-8138
> URL: https://issues.apache.org/jira/browse/GEODE-8138
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
>
> Currently when {{redis-port=0}} the Redis service is not enabled. Recently we
> added the ability to pick an ephemeral port by setting {{redis-port=-1}}.
> However the typical norm is that a port of {{0}} should indicate the use of
> an ephemeral port.
> If we allow this then we need a different way of enabling/disabling the
> service.
> One possibility is that the service is disabled when {{redis-port=-1}}. (or <
> 0). However anyone already setting the property to {{0}} would then suddenly
> activate the service.
> Another possibility is to add a new Geode property to explicitly
> enable/disable the service. (Off by default). That way users, switching to
> this version, would still experience the same behavior regardless of their
> {{redis-port}} setting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
