[
https://issues.apache.org/jira/browse/GEODE-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111491#comment-17111491
]
ASF GitHub Bot commented on GEODE-8147:
---------------------------------------
prettyClouds commented on a change in pull request #5128:
URL: https://github.com/apache/geode/pull/5128#discussion_r427567548
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/RedisKeyCommandsFunctionExecutor.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.redis.internal.ByteArrayWrapper;
+import org.apache.geode.redis.internal.RedisCommandType;
+import org.apache.geode.redis.internal.RedisData;
+
+public class RedisKeyCommandsFunctionExecutor implements RedisKeyCommands {
+ private Region<ByteArrayWrapper, RedisData> region;
+
+ public RedisKeyCommandsFunctionExecutor(
+ Region<ByteArrayWrapper, RedisData> region) {
+ this.region = region;
+ }
+
+ @Override
+ public boolean del(ByteArrayWrapper key) {
+ return (boolean) CommandFunction.execute(RedisCommandType.DEL, key, new
Object[] {}, region);
Review comment:
yea, the static execute method looks a little weird to me as well.
I like the idea of having a simple interface other than the FunctionService
to expose the function call, but the name `execute` is definitely confusing.
Some kind of code sharing in the *FunctionExecutor classes is a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> key commands implement Function-Delta
> -------------------------------------
>
> Key: GEODE-8147
> URL: https://issues.apache.org/jira/browse/GEODE-8147
> Project: Geode
> Issue Type: New Feature
> Reporter: Murtuza Boxwala
> Priority: Major
>
> DELETE
> EXISTS
> RENAME
> should all implement function-delta
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
