[
https://issues.apache.org/jira/browse/GEODE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111377#comment-17111377
]
ASF GitHub Bot commented on GEODE-8145:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5130:
URL: https://github.com/apache/geode/pull/5130#discussion_r427478939
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
##########
@@ -1929,7 +1929,8 @@
* The static String definition of the <i>"redis-bind-address"</i> property
<a
* name="redis-bind-address"/a>
* </p>
- * <U>Description</U>: Specifies the bind address used by Redis API for Geode
+ * <U>Description</U>: Specifies the bind address used by Redis API for
Geode. If "" specified,
+ * the default is determined from the /etc/hosts file.
Review comment:
I feel like how the default will be determined is too specific. I doubt
we explicitly read the /etc/hosts file. It is probably something more like "the
default will be requested from the operating system". It might be worth looking
at our implementation and seeing what it actually does when the value is "".
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -487,6 +487,27 @@ off-heap-memory-size=120g</code></pre></td>
<td><em>not set</em></td>
</tr>
<tr>
+<td>redis-bind-address</td>
+<td>Specifies the bind address used by Redis API for <%=vars.product_name%>.
If "" or no bind address
+specified, the default is determined from the `/etc/hosts` file.</td>
Review comment:
same comment about /etc/hosts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Redis configuration properties to gemfire_properties.html
> -------------------------------------------------------------
>
> Key: GEODE-8145
> URL: https://issues.apache.org/jira/browse/GEODE-8145
> Project: Geode
> Issue Type: Improvement
> Components: docs, redis
> Reporter: Sarah Abbey
> Priority: Minor
>
> redis-password, redis-bind-address, and redis-port need to be added to this
> page
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
