[
https://issues.apache.org/jira/browse/GEODE-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107151#comment-17107151
]
ASF GitHub Bot commented on GEODE-8130:
---------------------------------------
lgtm-com[bot] commented on pull request #5067:
URL: https://github.com/apache/geode/pull/5067#issuecomment-628524201
This pull request **introduces 4 alerts** when merging
1e1fc3b49e20bd58d86b83451c5ae2beba542012 into
d402351279cf4e81184a0ae8411778048858eee8 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-67ba3835d904918618f6e3fc9a2db0534a2ab22d)
**new alerts:**
* 4 for Non\-synchronized override of synchronized method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change the way redis uses geode regions to save memory and fix race conditions
> ------------------------------------------------------------------------------
>
> Key: GEODE-8130
> URL: https://issues.apache.org/jira/browse/GEODE-8130
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Priority: Major
>
> Currently the geode redis implementation uses a replicate region to hold
> every redis key as the region key (as a String object) and the region value
> is an enum describing the type. Another partitioned regioni is used to also
> store the redis key as the region key (as a ByteArrayWrapper object) and the
> region value is an object that is basically a Set or HashMap.
> This uses extra memory, the replicate does not scale well, is slower
> (updating two regions is slower than one region), and trying to update two
> regions to hold the same logical redis "key" has race conditions which can
> lead to inconsistent data.
> The solution is to have a single partitioned region that can hold multiple
> types of data (sets, hashes, strings, lists, etc).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
