[ 
https://issues.apache.org/jira/browse/GEODE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104941#comment-17104941
 ] 

ASF subversion and git services commented on GEODE-8103:
--------------------------------------------------------

Commit 4c5788d3b1b37bd284e93fdda4b78486aad7c9b8 in geode's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4c5788d ]

GEODE-8103: Renames SniSocketFactory to SniProxySocketFactory (#5092)



> Rename SniSocketFactory to SniProxySocketFactory for consistency.
> -----------------------------------------------------------------
>
>                 Key: GEODE-8103
>                 URL: https://issues.apache.org/jira/browse/GEODE-8103
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>    Affects Versions: 1.13.0, 1.14.0
>            Reporter: Jacob Barrett
>            Priority: Major
>             Fix For: 1.13.0, 1.14.0
>
>
> The class SniSocketFactory should be renamed SniProxySocketFactory. The class 
> in question produces objects of type SniProxySocket. An "SNI socket" isn’t a 
> thing but an SNI proxy is a thing. The factory class that produces proxy 
> socket factories (yes a meta factory) ProxySocketFactories uses the 
> “ProxySocket” name as well. It fells very inconsistent with all the other 
> classes that make up with API for SniSocketFactory to not have a proxy in it 
> and be called SniProxySocketFactory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to