[
https://issues.apache.org/jira/browse/GEODE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101014#comment-17101014
]
ASF GitHub Bot commented on GEODE-8035:
---------------------------------------
agingade commented on a change in pull request #5014:
URL: https://github.com/apache/geode/pull/5014#discussion_r419807590
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
##########
@@ -521,12 +521,12 @@ void create(InternalCache cache)
cache.initializePdxRegistry();
- for (DiskStore diskStore : diskStores.values()) {
+ diskStores.values().parallelStream().forEach(diskStore -> {
DiskStoreAttributesCreation creation = (DiskStoreAttributesCreation)
diskStore;
if (creation != pdxRegDSC) {
createDiskStore(creation, cache);
}
- }
+ });
Review comment:
If all the disk store is on the same disk-mount (or same disk
controller) doing it in the multi thread may be slower (due to read seek
jumping from one location to other). In that case, is it a good idea to have
default behavior to be single threaded and have system property to use multiple
thread or visa versa.
User may configure different disk store on the same disk-controller, to
isolate the region persistent files, which is commonly done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Parallel Disk Store Recovery when Cluster Restarts
> --------------------------------------------------
>
> Key: GEODE-8035
> URL: https://issues.apache.org/jira/browse/GEODE-8035
> Project: Geode
> Issue Type: Improvement
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeCommons
>
> Currently, when Geode cluster restarts, the disk store recovery is
> serialized. When all regions share the same disk store, the restart process
> is time consuming. To improve the performance, different regions can use
> different disk stores with different disk controllers. And adding parallel
> disk store recovery. This is expected to significantly reduce the time to
> restart Geode cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
