[
https://issues.apache.org/jira/browse/GEODE-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100290#comment-17100290
]
ASF GitHub Bot commented on GEODE-8072:
---------------------------------------
gesterzhou commented on a change in pull request #5053:
URL: https://github.com/apache/geode/pull/5053#discussion_r420437837
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/InternalFunctionExecutionServiceImpl.java
##########
@@ -116,6 +117,11 @@ public Execution onRegion(Region region) {
throw new FunctionException("Region instance passed is null");
}
+ if (region.getAttributes() == null) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When cache is closing, the lucene query might still on-going, some NPE could
> happen
> -----------------------------------------------------------------------------------
>
> Key: GEODE-8072
> URL: https://issues.apache.org/jira/browse/GEODE-8072
> Project: Geode
> Issue Type: Improvement
> Reporter: Xiaojian Zhou
> Priority: Major
>
> when the cache is closing, what detected recently is:
> RROR util.TestException: Got unexpected exception
> java.lang.NullPointerException
> at
> org.apache.geode.internal.cache.execute.InternalFunctionExecutionServiceImpl.onRegion(InternalFunctionExecutionServiceImpl.java:120)
> at
> org.apache.geode.cache.execute.FunctionService.onRegion(FunctionService.java:76)
> at
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.onRegion(PageableLuceneQueryResultsImpl.java:116)
> at
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.getValues(PageableLuceneQueryResultsImpl.java:110)
> at
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.getHitEntries(PageableLuceneQueryResultsImpl.java:91)
> at
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.advancePage(PageableLuceneQueryResultsImpl.java:139)
> at
> org.apache.geode.cache.lucene.internal.PageableLuceneQueryResultsImpl.hasNext(PageableLuceneQueryResultsImpl.java:148)
> It's not caused by any recently code changes, it's just a deep buried race
> condition triggered.
> I propose a simple fix to just check the null and throw an exception which
> could be handled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
