[
https://issues.apache.org/jira/browse/GEODE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099093#comment-17099093
]
ASF GitHub Bot commented on GEODE-8060:
---------------------------------------
kirklund opened a new pull request #5041:
URL: https://github.com/apache/geode/pull/5041
I found and fixed the issues causing memcached IntegrationJUnitTest to fail.
Please re-review and hopefully it should pass all precheckin jobs this time.
I hate creating a special package-private method just for the test BUT I
can't think of an effective test without getting some sort of state from
GemFireCacheImpl that identifies which call or which thread actually performed
the close.
Without identifying which call or thread performed the close, the test
devolves to just asserting that two threads can call close but it can't really
assert which call did the actual work of closing GemFireCacheImpl. From a
really high level, we don't really care. But at a low level, we don't want the
2nd callers to return before the 1st caller has finished the close (doesn't
matter if the 1st caller returns from close() after 2nd callers though which is
what causes the flakiness).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GemFireCacheImplCloseTest.close_blocksUntilFirstCallToCloseCompletes fails
> intermittently
> -----------------------------------------------------------------------------------------
>
> Key: GEODE-8060
> URL: https://issues.apache.org/jira/browse/GEODE-8060
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
>
> {noformat}
> org.apache.geode.internal.cache.GemFireCacheImplCloseTest >
> close_blocksUntilFirstCallToCloseCompletes FAILED
> org.junit.ComparisonFailure: [ThreadId1=47 and threadId2=49]
> expected:<4[7]L> but was:<4[9]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.GemFireCacheImplCloseTest.close_blocksUntilFirstCallToCloseCompletes(GemFireCacheImplCloseTest.java:225)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
