[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098606#comment-17098606
]
ASF GitHub Bot commented on GEODE-7971:
---------------------------------------
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r419179060
##########
File path:
geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd
##########
@@ -675,6 +675,7 @@ As of 6.5 roll-oplogs is deprecated. Use disk-store-name
instead.
alert-threshold CDATA #IMPLIED
dispatcher-threads CDATA #IMPLIED
order-policy CDATA #IMPLIED
+ group-transaction-events (false | true) #IMPLIED
Review comment:
I finally figured out that it was not needed to change the dtd files.
But I had to change
CacheXmlGenerator so that the group-transaction-events attribute was not
added to the gateway sender in case the cache.xml version was older than Geode
1.0. Without this change, the following test cases were failing:
```
org.apache.geode.cache.CacheXml80GatewayDUnitTest >
testGatewaySenderWithSubstitutionFilter FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit10230339244221650502/XML_8_0/CacheXml80GatewayDUnitTest_testGatewaySenderWithSubstitutionFilter.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 458; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
org.apache.geode.cache.CacheXml70GatewayDUnitTest >
testParallelGatewaySender FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit5316048290838435700/XML_7_0/CacheXml70GatewayDUnitTest_testParallelGatewaySender.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 422; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
org.apache.geode.cache.CacheXml70GatewayDUnitTest > testSerialGatewaySender
FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit13002812494872484215/XML_7_0/CacheXml70GatewayDUnitTest_testSerialGatewaySender.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 423; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
> ----------------------------------------------------------------------------
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
