[
https://issues.apache.org/jira/browse/GEODE-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091016#comment-17091016
]
ASF GitHub Bot commented on GEODE-7953:
---------------------------------------
upthewaterspout commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r414191117
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/DataSerializableFixedID.java
##########
@@ -225,7 +225,10 @@
byte REMOVE_CACHESERVER_PROFILE_UPDATE = -19;
- // IDs -18 through -10 unused
+ byte REGION_REDUNDANCY_STATUS = -18;
+ byte RESTORE_REDUNDANCY_RESULTS = -17;
Review comment:
Nitpick - but maybe we should save these small message ids for more
frequent messages?
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/control/ResourceManager.java
##########
@@ -77,6 +78,21 @@
*/
Set<RebalanceOperation> getRebalanceOperations();
+ /**
+ * Creates a class for defining and starting restore redundancy operations.
Review comment:
I think we should improve these javadocs and maybe clarify the
difference between "restore redundancy" and rebalance. Restore redundancy is
really just a subset of the rebalance operation - there is no need to invoke
both, for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create Restore Redundancy Internal API
> --------------------------------------
>
> Key: GEODE-7953
> URL: https://issues.apache.org/jira/browse/GEODE-7953
> Project: Geode
> Issue Type: New Feature
> Components: regions
> Reporter: Donal Evans
> Assignee: Donal Evans
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Introduce an internal API to allow redundancy to be restored and primary
> bucket hosts reassigned without necessitating a full rebalance.
> As described in the RFC found here:
> https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
