[
https://issues.apache.org/jira/browse/GEODE-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090802#comment-17090802
]
ASF GitHub Bot commented on GEODE-7851:
---------------------------------------
jinmeiliao commented on a change in pull request #4988:
URL: https://github.com/apache/geode/pull/4988#discussion_r414006325
##########
File path: geode-pulse/build.gradle
##########
@@ -95,6 +94,9 @@ dependencies {
// added only to ensure common version with other geode modules
runtimeOnly('org.slf4j:slf4j-api')
+ runtimeOnly('org.apache.logging.log4j:log4j-slf4j-impl') {
+ exclude module: 'slf4j-api'
Review comment:
I believe by declaring `runtimeOnly('org.slf4j:slf4j-api')` explicitly
will use the version we chose specifically, if we only do
`runtimeOnly('org.apache.logging.log4j:log4j-slf4j-impl')`, then the version
will depend on whatever version log4j-slf4j-impl uses.
doing this:
runtimeOnly('org.slf4j:slf4j-api')
runtimeOnly('org.apache.logging.log4j:log4j-slf4j-impl')
will end up using the versions we declare for both jars.
If I understand how gradle dependency works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should support OAuth2 authorization code flow
> ---------------------------------------------------
>
> Key: GEODE-7851
> URL: https://issues.apache.org/jira/browse/GEODE-7851
> Project: Geode
> Issue Type: New Feature
> Components: docs, pulse
> Reporter: Jinmei Liao
> Assignee: Dale Emery
> Priority: Major
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> Instead of using username/password to log in to pulse, pulse should redirect
> to a configured authentication provider to get access token to login.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
