[ https://issues.apache.org/jira/browse/GEODE-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086211#comment-17086211 ]
ASF subversion and git services commented on GEODE-8000: -------------------------------------------------------- Commit 311797a133d92583389fbd9d71ffa6cdb68ce147 in geode's branch refs/heads/mass-test-run from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=311797a ] GEODE-8000: refactor test command mocks (#4961) > Remove unnecessary mock from Redis Executor Unit tests > ------------------------------------------------------ > > Key: GEODE-8000 > URL: https://issues.apache.org/jira/browse/GEODE-8000 > Project: Geode > Issue Type: Test > Reporter: Murtuza Boxwala > Priority: Major > Fix For: 1.13.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Stopped mocking the Command class in the Redis *Executor Unit tests. > The Command class just holds data, and doesn't encapsulate any complex > behavior. Mocking its members makes the code more difficult to change and > the tests more brittle. -- This message was sent by Atlassian Jira (v8.3.4#803005)