[
https://issues.apache.org/jira/browse/GEODE-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052650#comment-17052650
]
ASF subversion and git services commented on GEODE-7808:
--------------------------------------------------------
Commit 4b06a7ae04e3eb3e32d8a6a96c7eb5e5d3269df0 in geode's branch
refs/heads/feature/GEODE-7665 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4b06a7a ]
Revert "GEODE-7808: standardize on use of HostAndPort to form client-side
connections (#4743)" (#4761)
This reverts commit 0af626462642c6352840cd6e81a5265c74045c7f.
That commit seems to have caused a severe performance drop in several
Benchmark tests:
org.apache.geode.benchmark.tests.PartitionedGetBenchmark
average ops/second Baseline: 981794.46 Test: 41239.82
Difference: -95.8%
org.apache.geode.benchmark.tests.ReplicatedGetBenchmark
average ops/second Baseline: 972769.18 Test: 41299.96
Difference: -95.8%
org.apache.geode.benchmark.tests.PartitionedNonIndexedQueryBenchmark
average ops/second Baseline: 90.05 Test: 70.52
Difference: -21.7%
> standardize on use of LocatorAddress/HostAddress for connection formation
> -------------------------------------------------------------------------
>
> Key: GEODE-7808
> URL: https://issues.apache.org/jira/browse/GEODE-7808
> Project: Geode
> Issue Type: Improvement
> Components: membership, messaging
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Fix For: 1.13.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> We currently use InetAddress and InetSocketAddress in many places to identify
> locators, servers and peers. Some work has been done in the past couple of
> years to reduce the use of these in order to accommodate changes in IP
> addresses due to various causes. The class LocatorAddress was created to
> help with this and it is able to hold a host name without resolving it until
> that resolution is needed to form a tcp/ip connection.
> These days we are seeing more and more movement into cloud computing and the
> need to accommodate IP address changes is becoming a bigger issue. To that
> end we would like to change our primary client/server and WAN communication
> interfaces to stop taking InetAddresses and InetSocketAddresses as arguments
> and, instead, take something like a LocatorAddress that can hold an
> unresolved hostname that our communication implementations will resolve when
> needed.
> To that end we should also remove the hostname->inetaddress cache in
> SocketCreator and rely on the operating system's DNS cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
