[ 
https://issues.apache.org/jira/browse/GEODE-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Godwin resolved GEODE-7517.
--------------------------------
    Resolution: Fixed

Fixed with following commit:


Commit 21fce819826f79e6f52adb829a5b2636a1213d9a in geode's branch 
refs/heads/develop from Kirk Lund
 [ [https://gitbox.apache.org/repos/asf?p=geode.git;h=21fce81] ]

GEODE-5407: Fix JMXMBeanReconnectDUnitTest
 * Rewrite test with standard Geode and JMX APIs
 * Use CountDownLatch instead of Blackboard
 * Use SharedErrorCollector for remote listener errors
 * Always consistently use Awaitility before checking GemFire MXBeans

Co-authored-by: Ivan Godwin <igod...@pivotal.io>

> JMXMBeanReconnectDUnitTest.testLocalBeans_MaintainServerAndCrashLocator
> -----------------------------------------------------------------------
>
>                 Key: GEODE-7517
>                 URL: https://issues.apache.org/jira/browse/GEODE-7517
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mark Hanson
>            Assignee: Ivan Godwin
>            Priority: Major
>              Labels: flaky
>
> Failures found during mass test runs.
> {noformat}
>          testLocalBeans_MaintainServerAndCrashLocator       
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1940
>          testLocalBeans_MaintainServerAndCrashLocator       
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1845
>  {noformat}
> Stack trace from 1940 run
> {noformat}
> org.awaitility.core.ConditionTimeoutException: Condition with alias 'Locators 
> must agree on the state of the system' didn't complete within 300 seconds 
> because assertion condition defined as a lambda expression in 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest 
> Expecting:
>   <[GemFire:service=Region,name="/test-region-1",type=Distributed,
>     GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
>     GemFire:service=AccessControl,type=Distributed,
>     GemFire:service=FileUploader,type=Distributed,
>     GemFire:service=System,type=Distributed,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-0,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-0,
>     GemFire:service=Locator,type=Member,member=locator-0,
>     GemFire:type=Member,member=locator-0,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-1,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-1,
>     GemFire:service=Locator,type=Member,member=locator-1,
>     GemFire:type=Member,member=locator-1,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-2,
>     GemFire:service=CacheServer,port=42991,type=Member,member=server-2,
>     GemFire:type=Member,member=server-2,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-3,
>     GemFire:service=CacheServer,port=41287,type=Member,member=server-3,
>     GemFire:type=Member,member=server-3]>
> to contain exactly (and in same order):
>   <[GemFire:service=Region,name="/test-region-1",type=Distributed,
>     GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
>     GemFire:service=AccessControl,type=Distributed,
>     GemFire:service=FileUploader,type=Distributed,
>     GemFire:service=System,type=Distributed,
>     GemFire:service=Locator,type=Member,member=locator-0,
>     GemFire:type=Member,member=locator-0,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-1,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-1,
>     GemFire:service=Locator,type=Member,member=locator-1,
>     GemFire:type=Member,member=locator-1,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-2,
>     GemFire:service=CacheServer,port=42991,type=Member,member=server-2,
>     GemFire:type=Member,member=server-2,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-3,
>     GemFire:service=CacheServer,port=41287,type=Member,member=server-3,
>     GemFire:type=Member,member=server-3]>
> but some elements were not expected:
>   
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-0,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-0]>
> .
>       at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145)
>       at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:122)
>       at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
>       at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902)
>       at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:723)
>       at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.before(JMXMBeanReconnectDUnitTest.java:94)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
>       at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>       at 
> org.apache.geode.test.junit.rules.serializable.SerializableExternalResource$1.evaluate(SerializableExternalResource.java:38)
>       at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
>       at 
> org.apache.geode.test.dunit.rules.ClusterStartupRule$1.evaluate(ClusterStartupRule.java:138)
>       at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>       at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>       at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>       at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>       at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>       at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>       at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>       at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>       at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>       at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>       at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:118)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>       at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>       at 
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:175)
>       at 
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:157)
>       at 
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
>       at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
>       at 
> org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>       at 
> org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
>       at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.AssertionError: 
> Expecting:
>   <[GemFire:service=Region,name="/test-region-1",type=Distributed,
>     GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
>     GemFire:service=AccessControl,type=Distributed,
>     GemFire:service=FileUploader,type=Distributed,
>     GemFire:service=System,type=Distributed,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-0,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-0,
>     GemFire:service=Locator,type=Member,member=locator-0,
>     GemFire:type=Member,member=locator-0,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-1,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-1,
>     GemFire:service=Locator,type=Member,member=locator-1,
>     GemFire:type=Member,member=locator-1,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-2,
>     GemFire:service=CacheServer,port=42991,type=Member,member=server-2,
>     GemFire:type=Member,member=server-2,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-3,
>     GemFire:service=CacheServer,port=41287,type=Member,member=server-3,
>     GemFire:type=Member,member=server-3]>
> to contain exactly (and in same order):
>   <[GemFire:service=Region,name="/test-region-1",type=Distributed,
>     GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
>     GemFire:service=AccessControl,type=Distributed,
>     GemFire:service=FileUploader,type=Distributed,
>     GemFire:service=System,type=Distributed,
>     GemFire:service=Locator,type=Member,member=locator-0,
>     GemFire:type=Member,member=locator-0,
>     
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-1,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-1,
>     GemFire:service=Locator,type=Member,member=locator-1,
>     GemFire:type=Member,member=locator-1,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-2,
>     GemFire:service=CacheServer,port=42991,type=Member,member=server-2,
>     GemFire:type=Member,member=server-2,
>     GemFire:service=Region,name="/test-region-1",type=Member,member=server-3,
>     GemFire:service=CacheServer,port=41287,type=Member,member=server-3,
>     GemFire:type=Member,member=server-3]>
> but some elements were not expected:
>   
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator-0,
>     
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator-0]>  
>     at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.lambda$before$0(JMXMBeanReconnectDUnitTest.java:95)
>       at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
>       at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:192)
>       at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:179)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>       ... 1 more {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to