[
https://issues.apache.org/jira/browse/GEODE-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund resolved GEODE-7515.
------------------------------
Resolution: Fixed
Fixed by these commits:
{noformat}
commit b48dc324b1f85688e333194d2d7e1636fa367dd7
Author: Kirk Lund <kl...@apache.org>
Date: Tue Dec 3 13:14:00 2019 -0800
GEODE-7513: Fix PersistentColocatedPartitionedRegionDistributedTest
Move flaky test coverage from distributed test to unit test.
Add more unit tests to SingleThreadColocationLoggerTest.
{noformat}
{noformat}
commit fc20f2fa07fc2e6534bad0046b05dd7f0941e06d
Author: Kirk Lund <kl...@apache.org>
Date: Wed Nov 6 16:59:51 2019 -0800
GEODE-4187: Fix PersistentColocatedPartitionedRegionDistributedTest
Fix flakiness in PersistentColocatedPartitionedRegionDistributedTest:
* GEODE-4187 testRebalanceDuringRecovery hang
* GEODE-5175 inline PersistentPartitionedRegionTestBase
* GEODE-6499 AsyncInvocation timeout
* GEODE-7082 testReplaceOfflineMemberAndRestartCreateColocatedPRLate
hang
Changes to fix flakiness:
* Clean up uses of AsyncInvocation
* Replace sleep with Mockito.verify using timeout()
* Replace sleep with CountDownLatch
* Use GeodeAwaitility timeout consistently
Extract integration tests:
* PersistentColocationIntegrationTest
* ModifyColocationIntegrationTest
Changes to product code:
* Move ColocationLogger to internal.cache.partitioned.colocation
* Extract factory and interfaces from ColocationLogger
* Create unit tests for ColocationLogger and factory
* Pass ColocationLoggerFactory into PartitionedRegion constructor
* Use ColocationLogger via interfaces instead of implementations
* Add getLogger(Class) to LogService
Clean up PersistentColocatedPartitionedRegionDistributedTest
* Fix uses of ArgumentCaptor and Mockito timeout
* Improve readability
* User TemporaryFolder Rule for all files
* Use RestoreSystemProperties Rule instead of try-finally blocks
* Use tearDown instead of try-finally blocks
* Update to non-deprecated APIs
* Replace try-catch blocks with AssertJ catchThrowable
* Use lambdas instead of SerializableRunnable instances
Other test file changes:
* Clean up PartitionedRegionTest
* Delete MockAppender
{noformat}
> PersistentColocatedPartitionedRegionDUnitTest has multiple issues.
> ------------------------------------------------------------------
>
> Key: GEODE-7515
> URL: https://issues.apache.org/jira/browse/GEODE-7515
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Mark Hanson
> Assignee: Kirk Lund
> Priority: Major
> Labels: flaky
>
> Mass test run failures..
>
> {noformat}
> testHierarchyOfColocatedChildPRsMissingGrandchild
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1889
> testHierarchyOfColocatedChildPRsMissingGrandchild
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1856
> testHierarchyOfColocatedChildPRsMissingGrandchild
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1828
> testHierarchyOfColocatedChildPRsMissingGrandchild
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1819
> testHierarchyOfColocatedChildPRsMissingGrandchild
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1752
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1889
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1856
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1829
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1828
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1819
> testMultipleColocatedChildPRsMissingWithSequencedStart
> https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/1752
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
