[
https://issues.apache.org/jira/browse/GEODE-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723395#comment-16723395
]
ASF subversion and git services commented on GEODE-3613:
--------------------------------------------------------
Commit f98547f4b52fe6b70b46de3823bf4bd3b1c9dd7b in geode's branch
refs/heads/feature/GEODE-6143-5 from [~demery]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f98547f ]
GEODE-3613: Allocate unique ports to containers
ServerContainer sometimes assigned the same port to multiple containers.
ServerContainer used AvailablePortHelper to allocate available ports.
Due to an inherent design flaw, AvailablePortHelper sometimes delivers
the same port number on multiple calls, which results in the same port
being used for multiple purposes.
ServerContainer now allocates ports using a single UniquePortSupplier
created by the test.
Additionally:
- Convert Cargo-based tests from DUnit base class to rule-based
- Start a new locator for each test
- Add cargo version to dependency-versions.properties
- Give each test class its own temp directory
- Fix bad check for container state validity
- Fix modify_war script to detect missing jar command and abort
- General test cleanup and de-duplication
- Announce start and end of each test to stdout
Co-Authored-By: Galen O'Sullivan <gosulli...@pivotal.io>
Co-Authored-By: Dale Emery <dem...@pivotal.io>
> Jetty9CachingClientServerTest failed in jenkins, unable to shutdown container
> -----------------------------------------------------------------------------
>
> Key: GEODE-3613
> URL: https://issues.apache.org/jira/browse/GEODE-3613
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Dan Smith
> Assignee: Dale Emery
> Priority: Major
> Labels: pull-request-available, swat
> Attachments: Test results - Class
> org.apache.geode.session.tests.Jetty9ClientServerTest.html
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This test failed in jenkins build #953 due to a failure to shutdown jetty
> Jetty9CachingClientServerTest.containersShouldShareDataRemovals
> Revision: 52305a8a7679d761a084f866c1253777345fb29e
> {noformat}
> org.codehaus.cargo.container.ContainerException: Failed to stop the Jetty
> 9.4.5.v20170502 container. Check the
> [/home/jenkins/jenkins-slave/workspace/Geode-nightly/geode-assembly/build/distributedTest65/cargo_logs/JETTY9_client-server_containersShouldShareDataRemovals_0_28531005061735378/container.log]
> file containing the container logs for more details.
> at
> org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:303)
> at
> org.apache.geode.session.tests.ServerContainer.stop(ServerContainer.java:210)
> at
> org.apache.geode.session.tests.ContainerManager.stopContainer(ContainerManager.java:105)
> at
> org.apache.geode.session.tests.ContainerManager.stopContainers(ContainerManager.java:115)
> at
> org.apache.geode.session.tests.ContainerManager.stopAllActiveContainers(ContainerManager.java:122)
> at
> org.apache.geode.session.tests.CargoTestBase.stop(CargoTestBase.java:71)
> at sun.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:147)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:129)
> at
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
> at
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.codehaus.cargo.container.ContainerException: Server port 23596
> did not shutdown within the timeout period [120000]
> at
> org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForPortShutdown(AbstractLocalContainer.java:448)
> at
> org.codehaus.cargo.container.spi.AbstractLocalContainer.waitForCompletion(AbstractLocalContainer.java:410)
> at
> org.codehaus.cargo.container.spi.AbstractLocalContainer.stop(AbstractLocalContainer.java:288)
> ... 53 more
> Standard Output
> Previously run tests: [RestAPIsOnMembersFunctionExecutionDUnitTest,
> RestAPIsOnGroupsFunctionExecutionDUnitTest,
> RestAPIOnRegionFunctionExecutionDUnitTest, Tomcat6Test,
> Tomcat7ClientServerTest, Jetty9CachingClientServerTest]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
