[
https://issues.apache.org/jira/browse/GEODE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702549#comment-16702549
]
ASF subversion and git services commented on GEODE-5228:
--------------------------------------------------------
Commit 348debe3d8273685d1d84ede6d201b448ae5b117 in geode's branch
refs/heads/develop from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=348debe ]
GEODE-5228: Stale status file is deleted before waiting for status response
file (#2850)
* There is a race condition in the product that manifests in tests, the issue
is that a stale status file can possibly be read before a new status file is
written.
* By deleting an existing status file, the file processor class will now wait
until the correct status file is written
* Status files are written in response to a status response file that the file
processor creates
> Existing or stale status file can potentially be read instead of the correct
> status response file
> -------------------------------------------------------------------------------------------------
>
> Key: GEODE-5228
> URL: https://issues.apache.org/jira/browse/GEODE-5228
> Project: Geode
> Issue Type: Bug
> Components: management
> Affects Versions: 1.1.0
> Reporter: Kirk Lund
> Assignee: Jason Huynh
> Priority: Minor
> Labels: ServerLauncher, ci, flaky, pull-request-available, swat
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The following test runs into a product race condition where the stale status
> file can possibly be read before the server launcher has a chance to start up.
> A work around for the issue is to ask for the status a second time. The
> first time may read the incorrect status file.
> {noformat}
> ServerLauncherRemoteFileIntegrationTest fails intermittently with
> IllegalStateException vf.gf.server.status is blank
> java.lang.IllegalStateException: Status file
> '/tmp/build/ae3c03f4/built-geode/tmp/junit5775773082469887234/vf.gf.server.status'
> is blank
> at
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
> at
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
> at
> org.apache.geode.distributed.ServerLauncher.statusWithWorkingDirectory(ServerLauncher.java:1102)
> at
> org.apache.geode.distributed.ServerLauncher.status(ServerLauncher.java:1050)
> at
> org.apache.geode.distributed.ServerLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(ServerLauncherRemoteIntegrationTestCase.java:198)
> at
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
> at
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
