[
https://issues.apache.org/jira/browse/GEODE-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684920#comment-16684920
]
ASF subversion and git services commented on GEODE-5873:
--------------------------------------------------------
Commit 7b252a628379d21fcafb34ce96357c434357a108 in geode's branch
refs/heads/develop from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7b252a6 ]
GEODE-5873: Fix VMProvider.invokeInEveryMember (#2812)
GEODE-5873: Fix VMProvider.invokeInEveryMember
Method `invokeInEveryMember` from `VMProvider` ends up being a no-op
when the array of members is empty or null.
- Fixed tests `CreateJndiBindingCommandDUnitTest` and
`DestroyJndiBindingCommandDUnitTest`, they weren't fully validating
the result.
- Method `invokeInEveryMember` now validates its parameters, throwing
an exception when the arguments are invalid.
> Some DUnitTest calls VMProvider.invokeInEveryMember without member arguments
> -----------------------------------------------------------------------------
>
> Key: GEODE-5873
> URL: https://issues.apache.org/jira/browse/GEODE-5873
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Jianxia Chen
> Assignee: Juan José Ramos Cassella
> Priority: Trivial
> Labels: beginner, pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In some of the DUnitTest, when it calls {{VMProvider.invokeInEveryMember}}
> without providing the member argument. And the result is an no-op, because
> there is no member to execute the {{SerializableRunnableIF}}. e.g. in
> {{CreateJndiBindingCommandDUnitTest}} and
> {{DestroyJndiBindingCommandDUnitTest}}, {{VMProvider.invokeInEveryMember}} is
> called without any member. It probably should be passed {{server1, server2.}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
