[
https://issues.apache.org/jira/browse/GEODE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662872#comment-16662872
]
ASF subversion and git services commented on GEODE-5861:
--------------------------------------------------------
Commit 404c64d827e23faf7c95de291bf5782ac53e07ad in geode's branch
refs/heads/feature/GEODE-5897 from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=404c64d ]
GEODE-5861: change jdbc connector to use jndi binding (#2650)
The jdbc connector now uses the existing "jndi-binding" xml/gfsh instead of
adding "jdbc-connection" xml/gfsh. All the old "jdbc-connection" commands have
been removed.
The create jndi-binding command has been changed in the following ways:
* the driver-class-name gfsh parameter is now optional.
* --url can be used as a replacement for --connnection-url
* the --type now defaults to SIMPLE (it used to not have a default).
* the --type=POOLED now defaults to creating a Hikari pool and an SPI exists to
customize the class
that implements the pool.
New External APIS:
DataSourceFactoryTest: this is the SPI users can implement for the POOLED
type.
Co-authored-by: @BenjaminPerryRoss
> JDBC Connector should use gfsh jndi-binding instead of jdbc-connection
> ----------------------------------------------------------------------
>
> Key: GEODE-5861
> URL: https://issues.apache.org/jira/browse/GEODE-5861
> Project: Geode
> Issue Type: Improvement
> Components: extensions
> Reporter: Jianxia Chen
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> In Geode there are two {{gfsh}} commands {{create jndi-binding}} and {{create
> jdbc-connection}} which try to accomplish the same goal. We should:
> * Change JDBC Connector to use the JNDI binding, instead of the JDBC
> Connection
> * Remove the {{create jdbc-connection}} command.
> * Remove the {{destroy jdbc-connection}} command
> * Remove the {{list jdbc-connection}} command.
> * Remove the {{describe jdbc-connection}} command
> * Remove the {{alter jdbc-connnection}} command
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
