[ https://issues.apache.org/jira/browse/GEODE-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636015#comment-16636015 ]
ASF subversion and git services commented on GEODE-5784: -------------------------------------------------------- Commit 7112b626794091a6c8e1fa90b8e263808993d752 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7112b62 ] GEODE-5784: Remove unused duplicate condition from AbstractConfig (#2545) Add new characterization tests for AbstractConfig.setAttribute > AbstractConfig.setAttribute contains duplicate condition with different > behaviors > --------------------------------------------------------------------------------- > > Key: GEODE-5784 > URL: https://issues.apache.org/jira/browse/GEODE-5784 > Project: Geode > Issue Type: Bug > Components: configuration > Reporter: Kirk Lund > Assignee: Kirk Lund > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > AbstractConfig.setAttribute contains duplicate condition with different > behaviors. It's not clear to me which is correct or if they should be > combined, so I think we'll have to do some testing. > {noformat} > } else if (valueType.equals(String[].class)) { > attObjectValue = value.split(","); > {noformat} > {noformat} > } else if (valueType.equals(String[].class)) { > if (value == null || value.length() == 0) { > attObjectValue = null; > } else { > String trimAttName = name.substring(0, name.length() - 1); > throw new UnmodifiableException( > > LocalizedStrings.AbstractConfig_THE_0_CONFIGURATION_ATTRIBUTE_CAN_NOT_BE_SET_FROM_THE_COMMAND_LINE_SET_1_FOR_EACH_INDIVIDUAL_PARAMETER_INSTEAD > .toLocalizedString(name, trimAttName)); > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)