[
https://issues.apache.org/jira/browse/GEODE-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614118#comment-16614118
]
Jinmei Liao edited comment on GEODE-5606 at 9/13/18 10:12 PM:
--------------------------------------------------------------
{quote}if we do ./gradlew :geode-core:wanTest --tests
GatewayReceiverXmlParsingValidationsJUnitTest
we would get: No tests found for given includes:
[GatewayReceiverXmlParsingValidationsJUnitTest](--tests filter)
{quote}
Looks like we are not ready to remove this runnerFactory yet.
was (Author: jinmeiliao):
{quote}if we do ./gradlew :geode-core:integrationTest --tests
GatewayReceiverXmlParsingValidationsJUnitTest
we would get: No tests found for given includes:
[GatewayReceiverXmlParsingValidationsJUnitTest](--tests filter)
{quote}
Looks like we are not ready to remove this runnerFactory yet.
> CategoryWithParameterizedRunnerFactory can be removed
> -----------------------------------------------------
>
> Key: GEODE-5606
> URL: https://issues.apache.org/jira/browse/GEODE-5606
> Project: Geode
> Issue Type: Improvement
> Components: tests
> Reporter: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Previously, this test runner was required for compatibility with any test
> using {{@RunWith(Parameterized.class)}}. See GEODE-4122 for details.
> The issue presented in GEODE-4122 et al that was solved by the
> {{CategoryWithParameterizedRunnerFactory}} is a non-issue in current versions
> of Gradle's JUnit plugin. This class and its annotated consumption can be
> safely removed.
> Steps taken to verify the above:
> * Check out {{0f8cd8e1ef12ab864f5b2ae7a0556156b249b432}} (fix for GEODE-4122)
> * Remove runner from some test using it, e.g.,
> {{GatewayReceiverXmlParsingValidationsJUnitTest}}
> * Clean environment ({{./gradlew clean}} and delete {{out}} and {{build}}
> directories)
> * Run target test, e.g., via {{./gradlew :geode-core:integrationTest --tests
> GatewayReceiverXmlParsingValidationsJUnitTest}}
> * Inspect test report
> * Note that no test was executed.
> * Check out {{develop}}
> * Clean environment again.
> * Remove runner from the same test
> * Execute test via same gradle command
> * Inspect test report
> * Note that the test was indeed run
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
