[ 
https://issues.apache.org/jira/browse/GEODE-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606398#comment-16606398
 ] 

ASF subversion and git services commented on GEODE-3778:
--------------------------------------------------------

Commit add995b2d29010ea29ca6bc20257a5eb708ce5c0 in geode's branch 
refs/heads/develop from Helena A. Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=add995b ]

GEODE-3778: Remove test FileWriters

* StringFileWriter assumed that the file would continue existing after
it is written to, but the FileProcessController.status() method
asynchronously removes the file after reading. That caused a race
condition which made this test flaky.
* removed the file writer classes because they didn't add value.

Signed-off-by: Dan Smith<dsm...@pivotal.io>


> FileProcessControllerIntegrationTest.status_withStatusRequestFileExists_doesNotFail
>  fails intermittently
> --------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3778
>                 URL: https://issues.apache.org/jira/browse/GEODE-3778
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Kirk Lund
>            Assignee: Helena Bales
>            Priority: Major
>              Labels: Ci, pull-request-available, swat
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> FileProcessControllerIntegrationTest tests FileProcessController which GFSH 
> uses to control running Locator and Server processes.
> So far this test has failed 3 times in CI with 2 different stacks:
> {noformat}
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest > 
> status_withStatusRequestFileExists_doesNotFail FAILED
>     java.lang.AssertionError: 
>     Expecting file:
>       </tmp/junit6965412555588538059/vf.gf.locator.status>
>     to exist.
>         at 
> org.apache.geode.internal.process.io.StringFileWriter.writeToFile(StringFileWriter.java:40)
>         at 
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest.status_withStatusRequestFileExists_doesNotFail(FileProcessControllerIntegrationTest.java:212)
> {noformat}
> {noformat}
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest > 
> status_withStatusRequestFileExists_doesNotFail FAILED
>     java.lang.InterruptedException: sleep interrupted
>         at java.lang.Thread.sleep(Native Method)
>         at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:143)
>         at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
>         at 
> org.apache.geode.internal.process.FileProcessControllerIntegrationTest.lambda$status_withStatusRequestFileExists_doesNotFail$4(FileProcessControllerIntegrationTest.java:206)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to