[ https://issues.apache.org/jira/browse/GEODE-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470606#comment-16470606 ]
ASF subversion and git services commented on GEODE-5183: -------------------------------------------------------- Commit 9f6eca31659560a9b34f952b5465ee844c8a66a3 in geode's branch refs/heads/develop from [~bschuchardt] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9f6eca3 ] GEODE-5183 require toData/fromData methods to correspond to a known version Methods beginning with toData or fromData in DataSerializable classes must now correspond to a valid Version or AnalyzeSerializablesJUnitTest will reject them. I've renamed a few methods and adjusted sanctionedDataSerializables.txt to remove them (fromDataProblem, fromData662) This closes #1928 > require toData/fromData methods for backward-compatibility to correspond to a > known version > ------------------------------------------------------------------------------------------- > > Key: GEODE-5183 > URL: https://issues.apache.org/jira/browse/GEODE-5183 > Project: Geode > Issue Type: Task > Components: serialization > Affects Versions: 1.7.0 > Reporter: Bruce Schuchardt > Assignee: Bruce Schuchardt > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Developers currently have no way of knowing if they correctly named their > toDataPre_ and fromDataPre_ methods. We need to at least have the > AnalyzeSerializables tests check to ensure that the toDataPre/fromDataPre > methods found in DataSerializables correspond to real Version instances. -- This message was sent by Atlassian JIRA (v7.6.3#76005)