[ 
https://issues.apache.org/jira/browse/GEODE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao updated GEODE-4735:
-------------------------------
    Description: 
get rid of Cache.getInstance call from CliUtils. Commands/functions/tests that 
use CliUtils should supply its own cache when using these functions.

Commands's access to cache should be injected when the commands are initialized.

  was:
Many of the CliUtil methods, particularly the "find member" methods, are 
exclusively used and indeed are on-line calls by GfshCommand methods.

The implementation of these methods should belong to the class that consumes 
them.

Moreover, it will make testing / mocking much easier.


> All CliUtils functions should take cache as a parameter if it needs one. 
> -------------------------------------------------------------------------
>
>                 Key: GEODE-4735
>                 URL: https://issues.apache.org/jira/browse/GEODE-4735
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> get rid of Cache.getInstance call from CliUtils. Commands/functions/tests 
> that use CliUtils should supply its own cache when using these functions.
> Commands's access to cache should be injected when the commands are 
> initialized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to