[
https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330042#comment-16330042
]
ASF GitHub Bot commented on GEODE-3391:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #188: GEODE-3391: Update
Transaction id to pass by references
URL: https://github.com/apache/geode-native/pull/188#discussion_r162251124
##########
File path: clicache/src/CacheTransactionManager.cpp
##########
@@ -35,14 +35,7 @@ namespace Apache
{
_GF_MG_EXCEPTION_TRY2
- try
- {
- m_nativeptr->get()->begin( );
- }
- finally
- {
- GC::KeepAlive(m_nativeptr);
- }
+ m_nativeptr->begin( );
Review comment:
Do you still need the keepalive here? This CLI object can collect while
still in the native begin method. Does the CLI object own and destroy the
native object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> eval shared_ptr usage in
> CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3391
> URL: https://issues.apache.org/jira/browse/GEODE-3391
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> evaluate shared_ptr usage and change to reference
> virtual void afterRegionDisconnected(Region& region)
> virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key,
> const UserDataPtr& aCallbackArgument) = 0;
> virtual void close(Region& rp);
> virtual void resume(const TransactionId& transactionId)
> virtual const TransactionId& getTransactionId() = 0;
> virtual void close(Region& rp);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
