[
https://issues.apache.org/jira/browse/GEODE-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329686#comment-16329686
]
ASF GitHub Bot commented on GEODE-4303:
---------------------------------------
PurelyApplied closed pull request #1294: GEODE-4303: Add assertions to nil test.
URL: https://github.com/apache/geode/pull/1294
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java
index 54db58eabd..48f93d8274 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java
@@ -14,6 +14,7 @@
*/
package org.apache.geode.management.internal.security;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
@@ -30,11 +31,9 @@
@Category({UnitTest.class, SecurityTest.class})
public class ResourcePermissionTest {
- private ResourcePermission context;
-
@Test
public void testEmptyConstructor() {
- context = new ResourcePermission();
+ ResourcePermission context = new ResourcePermission();
assertEquals(Resource.NULL, context.getResource());
assertEquals(Operation.NULL, context.getOperation());
assertEquals(ResourcePermission.ALL, context.getTarget());
@@ -42,13 +41,13 @@ public void testEmptyConstructor() {
@Test
public void testIsPermission() {
- context = new ResourcePermission();
+ ResourcePermission context = new ResourcePermission();
assertTrue(context instanceof WildcardPermission);
}
@Test
public void testConstructor() {
- context = new ResourcePermission();
+ ResourcePermission context = new ResourcePermission();
assertEquals(Resource.NULL, context.getResource());
assertEquals(Operation.NULL, context.getOperation());
assertEquals(ResourcePermission.ALL, context.getTarget());
@@ -95,7 +94,7 @@ public void testConstructor() {
@Test
public void testToString() {
- context = new ResourcePermission();
+ ResourcePermission context = new ResourcePermission();
assertEquals("NULL:NULL", context.toString());
context = new ResourcePermission(Resource.DATA, Operation.MANAGE);
@@ -110,16 +109,25 @@ public void testToString() {
@Test
public void testImplies() {
- WildcardPermission role = new WildcardPermission("*:read");
- role.implies(new ResourcePermission(Resource.DATA, Operation.READ));
- role.implies(new ResourcePermission(Resource.CLUSTER, Operation.READ));
-
- role = new WildcardPermission("*:read:*");
- role.implies(new ResourcePermission(Resource.DATA, Operation.READ,
"testRegion"));
- role.implies(new ResourcePermission(Resource.CLUSTER, Operation.READ,
"anotherRegion", "key1"));
-
- role = new WildcardPermission("data:*:testRegion");
- role.implies(new ResourcePermission(Resource.DATA, Operation.READ,
"testRegion"));
- role.implies(new ResourcePermission(Resource.DATA, Operation.WRITE,
"testRegion"));
+ // If caseSensitive=false, the permission string becomes lower-case, which
will cause failures
+ // when testing implication against our (case sensitive) resources, e.g.,
DATA
+
+ WildcardPermission context = new WildcardPermission("*:READ", true);
+ assertThat(context.implies(new ResourcePermission(Resource.DATA,
Operation.READ))).isTrue();
+ assertThat(context.implies(new ResourcePermission(Resource.CLUSTER,
Operation.READ))).isTrue();
+
+ context = new WildcardPermission("*:READ:*", true);
+ assertThat(context.implies(new ResourcePermission(Resource.DATA,
Operation.READ, "testRegion")))
+ .isTrue();
+ assertThat(context
+ .implies(new ResourcePermission(Resource.CLUSTER, Operation.READ,
"anotherRegion", "key1")))
+ .isTrue();
+
+ context = new WildcardPermission("DATA:*:testRegion", true);
+ assertThat(context.implies(new ResourcePermission(Resource.DATA,
Operation.READ, "testRegion")))
+ .isTrue();
+ assertThat(
+ context.implies(new ResourcePermission(Resource.DATA, Operation.WRITE,
"testRegion")))
+ .isTrue();
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ResourcePermissionTest is not asserting
> ---------------------------------------
>
> Key: GEODE-4303
> URL: https://issues.apache.org/jira/browse/GEODE-4303
> Project: Geode
> Issue Type: Bug
> Components: management, security, tests
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
>
> The test {{testImplies}} checks implications but does not assert on the
> values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
