[
https://issues.apache.org/jira/browse/GEODE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329611#comment-16329611
]
ASF GitHub Bot commented on GEODE-4305:
---------------------------------------
dschneider-pivotal commented on a change in pull request #1297: GEODE-4305:
encapsulate the concurrencyChecksEnabled field
URL: https://github.com/apache/geode/pull/1297#discussion_r162198416
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java
##########
@@ -1842,11 +1846,6 @@ public boolean getOffHeap() {
return this.offHeap;
}
- @Override
- public boolean isConcurrencyChecksEnabled() {
Review comment:
We found that we had two existing methods: isConcurrencyChecksEnabled and
getConcurrencyChecksEnabled. We wanted to change to only have one accessor
method. The "get" flavor not because it was better but because we have the
external interface RegionAttributes that AbstractRegion implements and has the
"get" flavor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Many places in the code access the "concurrencyChecksEnabled" field instead
> of calling getConcurrencyChecksEnabled
> ------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4305
> URL: https://issues.apache.org/jira/browse/GEODE-4305
> Project: Geode
> Issue Type: Improvement
> Components: regions
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
>
> The field "concurrencyChecksEnabled" on AbstractRegion is protected.
> Many other classes directly access this field instead of calling
> getConcurrencyChecksEnabled.
> The field should be made private and all access to it should be through
> methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
