[ 
https://issues.apache.org/jira/browse/GEODE-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314207#comment-16314207
 ] 

ASF GitHub Bot commented on GEODE-4231:
---------------------------------------

nabarunnag closed pull request #1236: GEODE-4231: Renamed FunctionAdapter test 
resource file to have .ser e…
URL: https://github.com/apache/geode/pull/1236
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/test/java/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.java
 
b/geode-core/src/test/java/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.java
index 7271d6820e..80535af406 100644
--- 
a/geode-core/src/test/java/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.java
+++ 
b/geode-core/src/test/java/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.java
@@ -1,7 +1,7 @@
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
  * agreements. See the NOTICE file distributed with this work for additional 
information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * copyright ownership. The ASF licenses this file to you under the Apache 
License, Version 2.0 (the
  * "License"); you may not use this file except in compliance with the 
License. You may obtain a
  * copy of the License at
  *
@@ -12,6 +12,7 @@
  * or implied. See the License for the specific language governing permissions 
and limitations under
  * the License.
  */
+
 package org.apache.geode.cache.execute;
 
 import static org.junit.Assert.*;
@@ -79,7 +80,7 @@ public void 
deserializePreGeodeFunctionAdapterShouldNotThrowIncompatibleExceptio
       throws Exception {
     FileInputStream fis =
         new FileInputStream(TestUtil.getResourcePath(getClass(), 
getClass().getSimpleName() + "."
-            + "serializedFunctionAdapterWithDifferentSerialVersionUID"));
+            + "serializedFunctionAdapterWithDifferentSerialVersionUID.ser"));
 
     DataInputStream dis = new VersionedDataInputStream(new 
DataInputStream(fis), Version.GFE_82);
     Object o = InternalDataSerializer.basicReadObject(dis);
diff --git 
a/geode-core/src/test/resources/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.serializedFunctionAdapterWithDifferentSerialVersionUID
 
b/geode-core/src/test/resources/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.serializedFunctionAdapterWithDifferentSerialVersionUID.ser
similarity index 100%
rename from 
geode-core/src/test/resources/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.serializedFunctionAdapterWithDifferentSerialVersionUID
rename to 
geode-core/src/test/resources/org/apache/geode/cache/execute/FunctionAdapterJUnitTest.serializedFunctionAdapterWithDifferentSerialVersionUID.ser


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> FunctionAdapter.serializedFunctionAdapterWithDifferentSerialVersionUID fails 
> rat checker
> ----------------------------------------------------------------------------------------
>
>                 Key: GEODE-4231
>                 URL: https://issues.apache.org/jira/browse/GEODE-4231
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>
> The Apache Geode Jenkins build rat check fails for the following file:
> FunctionAdapter.serializedFunctionAdapterWithDifferentSerialVersionUID
> This probably just needs to be renamed to a txt file or added to the ignored 
> list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to